Skip to content

Document Firstrade US equity platform support#42

Merged
Pigbibi merged 1 commit into
mainfrom
document-firstrade-us-equity-platform
May 20, 2026
Merged

Document Firstrade US equity platform support#42
Pigbibi merged 1 commit into
mainfrom
document-firstrade-us-equity-platform

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add FirstradePlatform to platform repository boundary examples
  • document firstrade as a value-native US equity runtime
  • include firstrade in weight-to-value execution translation notes

Tests

  • docs-only change

@Pigbibi Pigbibi merged commit df32c4b into main May 20, 2026
1 check passed
@Pigbibi Pigbibi deleted the document-firstrade-us-equity-platform branch May 20, 2026 12:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e94012449f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- `ibkr` adapter present
- `schwab` adapter present
- `longbridge` adapter present
- `firstrade` adapter present

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align required broker list with onboarding contract

Adding firstrade as a mandatory adapter in the support rule creates conflicting platform requirements across the docs: docs/us_equity_strategy_onboarding.md still defines a three-platform operating model (see lines 5, 18, and 97) and only documents IBKR/Schwab/LongBridge runtime env mapping. This inconsistency will cause strategy authors to follow incompatible checklists for supported_platforms and runtime readiness, which is likely to produce incorrect onboarding decisions unless the onboarding spec is updated in the same change.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant